Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: ignore cgroup2 failures (workaround until #2169 gets merged) #2195

Closed

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 31, 2019

CI seems to have been broken due to some bad rebase during merging multiple cgroup2 PRs: #2175

The failure is being fixed in #2169, but still waiting for review.

This PR updates .travis.yml to ignore the failure as a workaround until #2169 gets merged.

This PR can be closed if #2169 can get merged right now (and that's even better).

Signed-off-by: Akihiro Suda [email protected]

…#2169 gets merged)

CI seems to have been broken due to some bad rebase during merging multiple cgroup2 PRs: opencontainers#2175

The failure is being fixed in opencontainers#2169, but still waiting for review.

This PR updates .travis.yml to ignore the failure as a workaround until opencontainers#2169 gets merged.

This PR can be closed if opencontainers#2169 can get merged right now (and that's even better).

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title .travis.yml: ignore cgroup2 failures (workaround until #2169 gets mer… .travis.yml: ignore cgroup2 failures (workaround until #2169 gets merged) Dec 31, 2019
@AkihiroSuda
Copy link
Member Author

CRIU failures on cgroup v1 are unrelated

=== RUN   TestUsernsCheckpoint
--- FAIL: TestUsernsCheckpoint (0.57s)
    checkpoint_test.go:260: Did not restore the pipe correctly: 
=== RUN   TestCheckpoint
--- FAIL: TestCheckpoint (0.49s)
    checkpoint_test.go:260: Did not restore the pipe correctly: 

@cyphar
Copy link
Member

cyphar commented Jan 1, 2020

I'd prefer we merge #2169. I've just reviewed it.

@AkihiroSuda
Copy link
Member Author

#2169 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants